util: support SharedArrayBuffer in inspect#8612
Closed
alistairjcbrown wants to merge 1 commit intonodejs:masterfrom
Closed
util: support SharedArrayBuffer in inspect#8612alistairjcbrown wants to merge 1 commit intonodejs:masterfrom
alistairjcbrown wants to merge 1 commit intonodejs:masterfrom
Conversation
Update inspect utility to support readable output of SharedArrayBuffer
nodejs-github-bot
added
c++
Member
|
I think that would be better to merge my fix... #8587 |
Contributor
|
Shouldn't we wait for this feature to become publicly available in V8 first? |
Author
|
Looks like #8587 has been updated to be nearly the same as this PR (I've added comments on that PR). The only thing this PR has extra is an update to a comment in |
Member
|
For the time being I'll mark this as being blocked on #8587. Thank you! |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999 to
83c7a88
Compare
Member
|
Is this still needed? |
Member
|
Looks like everything except for the inspection test for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
util
Description of change
Update inspect utility to support readable output of
SharedArrayBufferobject.SharedArrayBufferis available behind theharmony_sharedarraybufferv8 flag. See the MDN docs for more details on what aSharedArrayBufferis.